[PATCH] More ldb/tdb tests.

Fri Nov 6 05:34:25 UTC 2015

On Thu, 2015-11-05 at 17:16 -0800, Jeremy Allison wrote:
> On Fri, Nov 06, 2015 at 02:01:45PM +1300, Andrew Bartlett wrote:
> > On Thu, 2015-11-05 at 16:20 -0800, Jeremy Allison wrote:
> > > On Thu, Oct 29, 2015 at 07:59:16AM +1300, Andrew Bartlett wrote:
> > > > On Fri, 2015-10-16 at 13:10 +1300, Andrew Bartlett wrote:
> > > > > On Mon, 2015-09-14 at 14:55 +1200, Adrian Cochrane wrote:
> > > > > > Dear Matthieu,
> > > > > > As you might've seen in the Samba mailing list, I've been
> > > > > > working
> > > > > > on 
> > > > > > testing your work on optimizing ldb and in code review
> > > > > > Volker
> > > > > > wanted 
> > > > > > some style changes (removal of the filter boolean and
> > > > > > shortening of
> > > > > > various lines).
> > > > > > 
> > > > > > Can you please add your signed-off by so we can get this
> > > > > > patch
> > > > > > in
> > > > > > with 
> > > > > > my tests?
> > > > > 
> > > > > Matthieu,
> > > > > 
> > > > > Can you please add your sign off to the attached patch, so we
> > > > > can
> > > > > proceed with getting this work into master?
> > > > 
> > > > Matthieu,
> > > > 
> > > > Can you please either indicate your signed off by on the
> > > > attached
> > > > patch, or on your original patch (that we can then just say we
> > > > modified)?
> > > > 
> > > > This is a small but important step to improving LDB performance
> > > > and
> > > > test coverage, and I would like to get it in to Samba.
> > > > 
> > > > Thanks,
> > > > 
> > > > Andrew Bartlett
> > > 
> > > Andrew, I just tried the contact number for Matthieu from
> > > the Team repository, and it's not up to date.
> > > 
> > > So currently Matthieu is uncontactable. What shall we
> > > do to move forward here ?
> > 
> > I did raise him on IRC earlier this week, see below, but frankly
> > this
> > is getting silly.  I propose we just push the patch, with a clear
> > commit message indicating that we (you and I) take responsibility
> > for
> > the contents of the patch, based on Matthieu's work.
> > 
> > (12:36:27) ekacnet: abartlet: humm
> > (12:36:37) ekacnet: thanks for the ping 
> > (12:36:57) ekacnet: I'll try to have a look soon, I'm somehow very
> > busy
> > (12:48:14) abartlet: I understand, but this has been dragging on
> > (12:50:43) abartlet: ekacnet: http://git.catalyst.net.nz/gw?p=samba
> > .git
> > ;a=commitdiff;h=29bc19c8e25339de86680f880c79278fc335cc22
> > (13:02:10) abartlet: ekacnet: or at least sign off on your old
> > patch: h
> > ttps://git.samba.org/mat/?p=mat/samba.git;a=commitdiff;h=2345bad58e
> > 4602
> > 64e16ef8bdae46dc6c6aa4d129
> > (13:03:25) abartlet: signing off on the rest of https://git.samba.o
> > rg/m
> > at/?p=mat/samba.git;a=shortlog;h=refs/heads/ldb_perfs would be
> > nice, so
> > we can improve on them and get them in
> > 
> > (I got no further reply)
> > 
> > I'm as frustrated as you that we can't get a yes or no, and that
> > our
> > strong preference for being polite and not putting in code without
> > the
> > author's OK is stopping any useful progress here.  In other
> > circumstances we would just re-write the patch, but that also seems
> > silly. 
> 
> I'm OK with that. Can you resend the entire patchset
> you'd like re-reviewed/pushing so I know I'm working
> with the right changes ?

Here is the patch set.  I've reviewed them, and made that clarifying
comment.  Sadly we don't get the performance benefit until we get other
(also unsigned!) patches from matthieu's ldb-perfs branch.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Move-ldb_-un-pack_data-into-ldb_module.h-for-tes.patch
Type: text/x-patch
Size: 2076 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0001-ldb-Move-ldb_-un-pack_data-into-ldb_module.h-for-tes.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ldb-torture-Test-ldb-unpacking-and-printing.patch
Type: text/x-patch
Size: 24445 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0002-ldb-torture-Test-ldb-unpacking-and-printing.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.patch
Type: text/x-patch
Size: 7502 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0003-ldb-introduce-ldb_unpack_data_withlist-to-unpack-par.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-lib-ldb-Use-better-variable-names-in-ldb_unpack_with.patch
Type: text/x-patch
Size: 2363 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0004-lib-ldb-Use-better-variable-names-in-ldb_unpack_with.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-lib-ldb-Use-talloc_memdup-because-we-know-the-length.patch
Type: text/x-patch
Size: 965 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0005-lib-ldb-Use-talloc_memdup-because-we-know-the-length.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-ldb-increment-version-due-to-added-ldb_unpack_data_w.patch
Type: text/x-patch
Size: 22317 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0006-ldb-increment-version-due-to-added-ldb_unpack_data_w.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-ldb-torture-test-ldb_unpack_data_withlist.patch
Type: text/x-patch
Size: 6908 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151106/5b61077f/0007-ldb-torture-test-ldb_unpack_data_withlist.bin>