[PATCHES] vfs_shadow_copy2: allow snapshots outside share's root

[Uri Simchoni]

On 10/30/2015 10:53 PM, Michael Adam wrote:
> On 2015-10-30 at 13:35 -0700, Jeremy Allison wrote:
>> On Fri, Oct 30, 2015 at 12:41:28AM +0200, Uri Simchoni wrote:
>>> Hi,
>>>
>>> I may just be misconfiguring shadow_copy2 here, but it does seem
>>> like a bug to me, so here's a fix and some tests.
>>>
>>> I filed https://bugzilla.samba.org/show_bug.cgi?id=11580 where I
>>> describe what kind of snapshot setup I'm using, and how I configure
>>> shadow_copy2 for that.
>>>
>>> - If there's a way to get this to work without the patch - I'd love
>>> to stand corrected
>>> - Haven't wrapped my mind around "snapshots everywhere" - need to
>>> verify this isn't broken by the fix, however I figured I'd submit
>>> the patch anyway to get feedback if it's a non-bug.
>> Hmmmm. Gonna take a look. I'm not sure if shadow_copy2 is
>> supposed to allow out-of-share snapshot location.
> I guess it should. I am going to have a look, too...
> But might be next week. :-)
>
> Cheers - Michael
In the meantime I've extended the test suite to cover wide and non-wide 
links and "snapdirseverywhere" and seems like my fix breaks 
"snapdirseverywhere" so stay tuned for a v2 patch :)

Thanks,
Uri.