Small Pidl change needed ...

Richard Sharpe realrichardsharpe at gmail.com
Fri May 15 07:41:30 MDT 2015


On Thu, May 14, 2015 at 11:36 PM, Stefan (metze) Metzmacher
<metze at samba.org> wrote:
> Am 14.05.2015 um 16:59 schrieb Richard Sharpe:
>> Hi folks,
>>
>> The current version of Pidl generates prototypes like this:
>>
>>    uint32 _echo_TestSleep(struct pipes_struct *p, struct echo_TestSleep *r);
>>
>> With the attached change, they are now like this:
>>
>>    uint32_t _echo_TestSleep(struct pipes_struct *p, struct echo_TestSleep *r);
>>
>> However, I am not convinced that it is the best change.
>>
>> Feedback welcome.
>
> We already have a mapTypeName() function.
>
> The attached patch should fix the problem.

Reviewed-by: Richard Sharpe <rsharpe at samba.org>
Tested-by: Richard Sharpe <rsharpe at samba.org>

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list