Emailing: 0001-Add-IPv6-support-to-ADS-client-side-LDAP-connects.-C.patch

[Ralph Böhme]

On Tue, May 12, 2015 at 10:23:24AM -0700, Jeremy Allison wrote:
> On Tue, May 12, 2015 at 04:27:03PM +0100, David Holder wrote:
> > Hi All,
> > 
> > The attached patch fixes a bug in Samba whereby client ADS LDAP
> > connections fail to IPv6-only DCs.
> > 
> > The fault was that the code assumed that a URI containing a literal
> > IPv6 address has the same format as a URI containing a literal IPv4
> > address in it. This assumption is wrong. For IPv6 URIs, the address
> > must be enclosed in square brackets.
> > 
> > E.g:
> > 
> > ldap://192.168.1.1
> > ldap://[2045::1]
> > 
> > Please review - thanks!
> 
> Reviewed with minor change (attached)
> 
> strstr(name, ":") doesn't
> cope with utf8 names.
> 
> strchr_m(name, ':')
> 
> does. Also added your 'Signed-off-by:'
> 
> With that LGTM. Can I get a second
> Team reviewer please ?

rb: me.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de