vfp_gpfs: ensure END_PROFILE is always called

Stefan (metze) Metzmacher metze at samba.org
Fri May 1 03:49:23 MDT 2015


Hi Ralph,

>  	SMB_VFS_HANDLE_GET_DATA(handle, config,
>  				struct gpfs_config_data,
>  				return -1);
>  
> -	if (linux_set_lease_sighandler(fsp->fh->fd) == -1)
> -		return -1;
> +	START_PROFILE(syscall_linux_setlease);
> +
> +	if (linux_set_lease_sighandler(fsp->fh->fd) == -1) {
> +		ret = -1;
> +		goto failure;
> +	}
>  
>  	if (config->leases) {
>  		/*
> @@ -219,6 +221,7 @@ static int vfs_gpfs_setlease(vfs_handle_struct *handle, files_struct *fsp,
>  
>  	END_PROFILE(syscall_linux_setlease);
>  
> +failure:
>  	return ret;
>  }

Don't we need +failure before the END_PROFILE(syscall_linux_setlease); line?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150501/bc00f0c2/attachment.pgp>


More information about the samba-technical mailing list