PATCH multi-channel & fd passing

Volker Lendecke Volker.Lendecke at SerNet.DE
Thu Mar 19 04:00:39 MDT 2015


On Thu, Mar 19, 2015 at 09:43:27AM +0000, Noel Power wrote:
> On 18/03/15 20:50, Jeremy Allison wrote:
> > On Wed, Mar 18, 2015 at 08:22:07PM +0100, Michael Adam wrote:
> >> Hi Noel,
> >>  
> [...]
> >> NAK on the second cosmetic patch. It removes an early
> >> return just to remove an anonymous block.
> >>
> >> Having early returns trumps anonymous blocks (IMHO).
> >>
> isn't the early return still there (just not as early ;-)) but.. anyway
> I think I was wrong to change the test from the explicit error condition
> (as msghdr_prep_fds already copes with fdlen == 0 and doesn't regard it
> as an error)
> How about this patch?, afaics the only purpose of that block is to avoid
> a warning about the declaration of the buf array

Sorry to step in without having the full context: What does
your patch aim to fix?

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de


More information about the samba-technical mailing list