[PATCH] samdb: Add NULL checks
David Disseldorp
ddiss at suse.de
Fri Mar 13 09:25:59 MDT 2015
On Fri, 13 Mar 2015 11:12:31 +0100, Volker Lendecke wrote:
> private_dir = talloc_strdup(data, secrets_ldb);
> + if (private_dir == NULL) {
> + return ldb_oom(ldb);
> + }
> p = strrchr(private_dir, '/');
> if (p) {
> *p = '\0';
> } else {
> private_dir = talloc_strdup(data, ".");
> + if (private_dir == NULL) {
> + return ldb_oom(ldb);
> + }
Please free @data before returning in both cases. The talloc_asprintf()
call should also be checked for failure...
514 secrets_ntdb = talloc_asprintf(private_dir, "%s/secrets.ntdb",
515 private_dir);
516 use_ntdb = file_exist(secrets_ntdb);
Cheers, David
More information about the samba-technical
mailing list