[PATCH] ctdb-locking: Back-off from logging every 10 seconds

Martin Schwenke martin at meltin.net
Thu Mar 5 04:29:27 MST 2015


On 5 March 2015 9:31:24 PM AEDT, Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:
>On Thu, Mar 05, 2015 at 04:27:35PM +1100, Amitay Isaacs wrote:
>> This patch prevents flooding of debug logs by locking code when a
>lock
>> helper is unable to obtain a lock for a long time.  Instead of
>logging
>> every 10 seconds, increase the interval to 100 seconds and 1000
>seconds
>> when the elapsed time reaches 100 seconds and 1000 seconds
>respectively.
>> 
>> Please review and push if ok.
>
>Pushed, thanks! I wonder if we can somehow generalize this
>pattern...
>
>Attached find two small patches on top of your patch.
>
>Review&push if ok.


I don't think you want the 2nd patch. debug_locks is static.  The environment variable can't change so we cache the value in the static.  We do that in a few places. 

peace & happiness,
martin



More information about the samba-technical mailing list