[PATCH v2 5/5] dns: always add authority records

[Kai Blin]

On 2015-07-30 23:05, Stefan Metzmacher wrote:

Hi Stefan,

>> @@ -673,7 +677,9 @@ struct tevent_req *dns_server_process_query_send(
>>   				      &state->answers, &state->ancount,
>>   				      &state->nsrecs, &state->nscount);
>>   		if (tevent_req_werror(req, err)) {
>> -			return tevent_req_post(req, ev);
>> +			if (!W_ERROR_EQUAL(err, DNS_ERR(NAME_ERROR))) {
>> +				return tevent_req_post(req, ev);
>> +			}
>
> This is wrong,
>
> You need to check if (!W_ERROR_EQUAL(err, DNS_ERR(NAME_ERROR)))
> before tevent_req_werror(req, err).

On a closer look, I don't actually need that at all, the important part 
happens in dns_server_process_query_recv now.

Thanks for the review, I'll resend. :)

Cheers,
Kai

-- 
Kai Blin
Samba Developer http://samba.team