[PATCHSET] Introduce SDB - a KDC backend abstraction

[Andrew Bartlett]

On Wed, 2015-07-29 at 13:36 +0200, Andreas Schneider wrote:
> Hello,
> 
> attached is a patchset which brings us again a step forward. It 
> introduces SDB 
> a KDC backend abstraction. It implements a sdb to hdb translation 
> layer.
> 
> I've gone through the patches with Alexander and we cleaned up the 
> interface 
> yesterday. It passes a full 'make test' on my machine.
> 
> I will plan to push it tomorrow.

I'm sorry to see this pushed in such a rush.  As I've said before, this
is a delicate area, and I would like to explicitly review each change
here, and to other parts of our KDC infrastructure.

It seems we now have a partial copy of the Heimdal ABI in our tree,
that if we diverge will cause some nasty challenges.  I still don't see
why couldn't we just keep the hdb structures, but if we must have this
half-copy, can we please have some assertions that the #defines and
bitmaps in sdb.h really are identical?

In particular, why was int2SDBFlags done in the sdb layer, rather than
in the hdb layer?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba