[PART2] [PATCHES] some cleanup to loadparm

Michael Adam obnox at samba.org
Wed Jul 22 20:06:37 UTC 2015


On 2015-07-22 at 15:56 -0400, Ira Cooper wrote:
> commit 87e2a4925a58db159452b3d9959cc36ecd24e202
> Author: Michael Adam <obnox at samba.org>
> Date:   Mon Jun 15 23:45:45 2015 +0200
> 
>     param: rename szLdapGroupSuffix -> _ldap_group_suffix
> 
>     Signed-off-by: Michael Adam <obnox at samba.org>
> 
> Does not compile.
> 
> [1321/4027] Compiling lib/param/util.c
> [1322/4027] Compiling lib/param/param_table.c
> [1323/4027] Compiling default/python/samba_python.empty.c
> ../lib/param/param_table.c:2821:13: error: ‘struct loadparm_global’ has no
> member named ‘_ldap_group_suffix’
>    .offset  = GLOBAL_VAR(_ldap_group_suffix),
>              ^
> [1324/4027] Compiling python/modules.c
> Waf: Leaving directory `/home/ira/samba/obnox/bin'
> Build failed:  -> task failed (err #1):
>     {task: cc param_table.c -> param_table_8.o}
> Makefile:8: recipe for target 'all' failed
> make: *** [all] Error 1
> ira at ira-t430:~/samba/obnox
> [/dev/pts/1](240/2)$ git log
> commit 87e2a4925a58db159452b3d9959cc36ecd24e202
> Author: Michael Adam <obnox at samba.org>
> Date:   Mon Jun 15 23:45:45 2015 +0200
> 
>     param: rename szLdapGroupSuffix -> _ldap_group_suffix
> 
>     Signed-off-by: Michael Adam <obnox at samba.org>
> 
> 
> ----
> 
> (Compile done on Fedora 22.)
> 
> I suspect that the other commits in the same pattern won't compile.

Gosh that is a rebase-artefact.
The following patch amends that but
that was actually supposed to be in
the first patch.

Sorry for the inconvenience, I did not
compile each patch after rebasing.

Will send an updated patch shortly.

Michael


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150722/9a5f4fb2/attachment.sig>


More information about the samba-technical mailing list