[PATCH v3] Seed random generator in main()

Jeremy Allison jra at samba.org
Mon Jul 6 23:24:03 UTC 2015


On Wed, Jun 24, 2015 at 11:18:21AM +0200, Volker Lendecke wrote:
> On Tue, Jun 23, 2015 at 09:19:35PM +0100, Robin McCorkell wrote:
> > While a decision is being made on the random number generation stuff,
> > the issue that this patch fixes remains a problem. At the moment,
> > shuffling for MSDFS and DC referrals is woefully poor, essentially being
> > the same in a given second. In addition, the built-in libc RNG is seeded
> > every request, which is really inefficient.
> > 
> > I know this patch isn't the way we ultimately want to go, but it does
> > fix the issue at hand, so reviews please? :)
> 
> Would it also help if instead of sys_random you used
> generate_random_buffer? This would avoid any further
> discussion about random generators and get your patches in
> more quickly I guess :-)

Yeah I agree. Robin, I am interested in getting your
patches in but the arguments over sys_random are just
causing needless delay.

Can you repost them using generate_random_buffer()
instead, and I'll help get them through the submissions
process.

Sorry for the delays.

Jeremy.


More information about the samba-technical mailing list