selftest: re-enable nss_winbind via nss_wrapper in the test-envs.

Andrew Bartlett abartlet at samba.org
Tue Feb 17 11:27:59 MST 2015


On Tue, 2015-02-17 at 18:32 +0100, Michael Adam wrote:
> On 2015-02-17 at 18:27 +0100, Michael Adam wrote:
> > On 2015-02-17 at 18:09 +0100, Stefan (metze) Metzmacher wrote:
> > > Hi Michael,
> > > 
> > > > diff --git a/python/samba/provision/__init__.py b/python/samba/provision/__init__.py
> > > > index 1603321..3e2397d 100644
> > > > --- a/python/samba/provision/__init__.py
> > > > +++ b/python/samba/provision/__init__.py
> > > > @@ -1476,8 +1476,8 @@ def fill_samdb(samdb, lp, names, logger, policyguid,
> > > >          return samdb
> > > >  
> > > >  
> > > > -SYSVOL_ACL = "O:LAG:BAD:P(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)"
> > > > -POLICIES_ACL = "O:LAG:BAD:P(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)(A;OICI;0x001301bf;;;PA)"
> > > > +SYSVOL_ACL = "O:LAG:BAD:P(A;OICI;0x001200a9;;;LA)(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)"
> > > > +POLICIES_ACL = "O:LAG:BAD:P(A;OICI;0x001200a9;;;LA)(A;OICI;0x001f01ff;;;BA)(A;OICI;0x001200a9;;;SO)(A;OICI;0x001f01ff;;;SY)(A;OICI;0x001200a9;;;AU)(A;OICI;0x001301bf;;;PA)"
> > > >  SYSVOL_SERVICE="sysvol"
> > > 
> > > Aren't these the hardcoded values windows clients expect to be there?
> > 
> > Could be. That is why I was asking for experts (like you) to
> > comment! :-)
> > 
> > > I guess changing them, just to let our test pass is wrong.
> > 
> > Ok. Does that mean the ACE values for the owner are completely
> > random? And the previous patch that does not adapt the NT ACL
> > but simply adapte the posix checks to the values that let
> > the test pass is better/correct?
> 
> More concretely, the attached patch..

This is much more like what I expected the fix to be (changing NSS
mappings might change some aspect of the stored posix ACL), but why does
the permission change from 6 to 7 (adding execute?)

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list