[PATCH] waf: Fix the build on openbsd

Jeremy Allison jra at samba.org
Tue Feb 10 14:18:56 MST 2015


On Tue, Feb 10, 2015 at 10:01:31PM +0100, Michael Adam wrote:
> Okaaaay, I think I misinterpreted the patch the first
> time. I *thought* that you were proposing to somehow
> track a number of patches to keep on top of our upstream
> copy... But instead of being proper wafadmin fixes,
> your proposed solution adds a place for us where to
> collect the patches to wafsamba that should fix stuff
> in wafadmin...
> 
> Hmmm, now that I understand it better, I am not entirely
> sure that I like it that much. :-)
> 
> I think we first need to come to a conclusion whether we
> want to override wafadmin function in wafsamba for the sake
> of not changing wafadmin or whether we want to rather change
> wafsamba instead...

Hurrah !

Yes, this is indeed the core issue, and why I think
Volker began to give up :-).

> This is definitely not a matter of "Show me a minimal fix
> and I'll +1 and push..".

Well that suggestion was based on the assumption
that we had decided on *not* changing wafadmin.

If we are changing wafadmin then we can fix this
properly instead, but it does diverge us from
upstream.


More information about the samba-technical mailing list