[PATCH] Fix bug(s) 11624 and 11195
Volker Lendecke
Volker.Lendecke at SerNet.DE
Wed Dec 16 20:26:14 UTC 2015
On Wed, Dec 16, 2015 at 11:57:50AM -0800, Jeremy Allison wrote:
> We're using a pointer as a DLINK_LIST
> head, but not correctly initializing it
> as a list_head when setting it up.
>
> A list head should have:
>
> list_head->prev = list_head
> list_head->next = NULL
>
> *not*:
>
> list_head->prev = NULL
> list_head->next = NULL
>
> This fixes the initialization to
> use the correct macro.
>
> Please review and push if
> happy !
Very happy, pushed!
It's always both fascinating and depressing to find these
ancient bugs... Sometimes I believe that 1-10 bugs per 1000
lines is a bit exaggerated, but this tells me there might be
some truth to it.
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical
mailing list