[PATCH] ctdb: Some build fixes with clang

[Amitay Isaacs]

On Wed, Aug 19, 2015 at 4:31 PM, Amitay Isaacs <amitay at gmail.com> wrote:

> On Wed, Aug 19, 2015 at 4:05 PM, Volker Lendecke <
> Volker.Lendecke at sernet.de> wrote:
>
>> On Wed, Aug 19, 2015 at 03:57:57PM +1000, Amitay Isaacs wrote:
>> > On Wed, Aug 19, 2015 at 3:37 PM, Volker Lendecke <
>> Volker.Lendecke at sernet.de>
>> > wrote:
>> >
>> > > Hi!
>> > >
>> > > Review&push appreciated!
>> > >
>> > > Thanks,
>> > >
>> > > Volker
>> > >
>> >
>> > How did you manage to build ctdb with clang?  :-)  I can't go past
>> building
>> > socket_wrapper specially with -Wcast-align -Wcast-qual.  I have to
>> disable
>> > those flags to get anywhere.
>>
>> Hmm. I get tons of cast-align warnings, but on FreeBSD
>> somehow none of these count as errors.
>>
>> Volker
>>
>>
> I tried building ctdb with Clang on Fedora 22 (LLVM 3.5.0) and got tons of
> errors.
> What version does FreeBSD have?
>
> More complete clean up of CTDB with clang is here:
>
>
> https://git.samba.org/?p=amitay/samba.git;a=shortlog;h=refs/heads/ctdb-clang
>
> I have not split the changes.  They are all in one big chunk.
>
> Amitay.
>
>
Forgot to mention that some of the fixes are based on the result of LLVM
static analyzer.

Amitay.