AES crypto performance improvements

Ralph Böhme rb at sernet.de
Mon Aug 17 14:07:19 UTC 2015


On Mon, Aug 17, 2015 at 03:39:09PM +0200, Stefan Metzmacher wrote:
> Am 14.08.2015 um 15:28 schrieb Stefan Metzmacher:
> > Am 13.08.2015 um 23:22 schrieb Stefan Metzmacher:
> >> Hi,
> >>
> >> while debugging poor performance of our SMB3 crypto
> >> I developed the following performance improvements.
> >>
> >> The aes_block_xor() improved by a factor of ~10.
> >> The aes_block_[r|l]shift() functions improved by 25%.
> >>
> >> Please review and push.
> >>
> >> The real solution will be to use hardware support,
> >> I've extended the work from Simo in the following branch
> >> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-smb-crypto
> >> (ignore the unrelated and directly reverted commits on top)
> >>
> >> But I'm not that happy with the abstraction yet.
> > 
> > There's a regression in the aes_ccm_128 optimization because that doesn't
> > have test cases... I'm working on it.
> 
> As a start I'd like to prefer aes-ccm for 4.3.0rc3.
> 
> Can someone review and push these patches to master?

lgtm! Will push.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de



More information about the samba-technical mailing list