PATCH: Moving the rejection of svhdx to vfs_default.c

Richard Sharpe realrichardsharpe at gmail.com
Sat Aug 15 02:49:39 UTC 2015


On Thu, Aug 13, 2015 at 1:08 AM, Stefan Metzmacher <metze at samba.org> wrote:
> Hi Richard,
>
>> +     if (in_context_blobs)
>> +             svhdx = smb2_create_blob_find(in_context_blobs,
>> +                                           SVHDX_OPEN_DEVICE_CONTEXT);
>
> Please read README.Coding.
>
> If statements should always have braces, this is a difference compared
> to the style of the linux kernel.

Actually, that is something about the Samba coding style that I very
much agree with.

It makes it much easier to add random DEBUG statements ...

> Regarding the functional change, I'm not sure.
> Please discuss this to the end with Michael,
> before pushing.
>
> Thanks!
> metze
>



-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list