[PATCH][PYTHON] Fix replPropertyMetaData sort order for schema extension attributes

[Andrew Bartlett]

On Tue, 2015-08-04 at 07:41 +0200, Stefan Metzmacher wrote:
> Am 03.08.2015 um 04:53 schrieb Andrew Bartlett:
> > On Thu, 2015-07-30 at 15:47 +1200, Andrew Bartlett wrote:
> > > On Tue, 2015-07-28 at 16:37 +1200, Andrew Bartlett wrote:
> > > > Comment on the attached patches would be most welcome.  I 
> > > > realise 
> > > > that
> > > > the assertion that dbcheck no longer flaps is untested, but I 
> > > > have
> > > > pinned down one cause.
> > > > 
> > > > Details of the initial symptoms are here:
> > > > 
> > > > https://lists.samba.org/archive/samba/2015-June/192485.html
> > > > https://bugzilla.samba.org/show_bug.cgi?id=10973#c8
> > > 
> > > Attached is a new patch for review.  This adds tests and so fixes 
> > > 
> > > more
> > > of the python integer checking.
> > > Thanks,
> > > Andrew Bartlett
> > 
> > New patches for this are now at 
> > git://git.samba.org/abartlet/samba.git
> > replmetadata-sort-minimal
> > 
> > This now includes tests by introducing this error into a the 
> > 4.1.0rc3
> > reference provision and confirming dbcheck finds and fixes it.
> > 
> > It also has fixes for our python integer handling, ensuring that we
> > give errors if a python integer won't fit into the C type of the 
> > PIDL
> > -generated structure it is representing.
> > 
> > Can I please have this reviewed into master?
> 
> I'm looking...
> 
> The first questions:
> 
> - Do we have a test that checks the objectClass sorting against the 
> LDAP
> server
>   (and passed against windows)?

No, not currently.  We should have it check that the correct
attributeID is added, that it is sorted, and that when entries are
modified, replaced or deleted, that the version is incremented. 

> - Please add BUG: https:... tags to the commit messages
>   We want to backport this at least to v4-3-test and v4-2-test, but
> maybe also to v4-1-test...

The key is to backport 61b978872fe86906611f64430b2608f5e7ea7ad8, then
these to fix up broken databases. 

The big remaining issue is that our msDS-IntID handling is totally
broken.  We use that only when pushing the values over the network with
GetNCChanges, but not during storage in replPropertyMetaData.  This
means for the an object with the same attribute modified on two servers
we can end up with metadata for an entry twice, once for each style of
attributeID.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba




-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150805/cedc0a25/signature.sig>