[PATCHES] more loadparm cleanup

Ira Cooper ira at samba.org
Thu Apr 30 13:48:36 MDT 2015


On Thu, Apr 30, 2015 at 1:42 PM, Michael Adam <obnox at samba.org> wrote:

> On 2015-04-30 at 07:48 -0400, Ira Cooper wrote:
> > On Thu, Apr 30, 2015 at 7:43 AM, Ralph Böhme <rb at sernet.de> wrote:
> > > On Wed, Apr 29, 2015 at 01:19:44AM +0200, Michael Adam wrote:
> > > > attached find code that cleans up our loadparm
> > > > by removing flags specific to swat which has
> > > > been removed.
> > > >
> > > > Note: the change that removes the flags from
> > > > the xml documents under docs-xml/smbdotconf
> > > > has been split into several commits, one per
> > > > subdirectory, for better overview. If desired,
> > > > these can also be squashed.
> > > >
> > > > Review/comments/push appreciated.
> > >
> > > in b886e93 you
> > >
> > >    keep ... FLAG_META, which might become useful.
> > >
> > > And then in the subsequent commit you
> > >
> > >    param: remove unused FLAG_META
> > >
> > > Any reason not to squash both and update the commit message?
>
> Yes, we should do that.
> I first omitted it and then changed my mind, forgot to squash.
>
> > I caught 1-2 more things... they are minor also.
> >
> > 03/22 Need to make sure the case matches in patch.
>
> Er, what do you mean here?
> That's the P_SEP patch.
>
>
That the comments put in, should have the same case as the parameter you
were removing...

-Ira


More information about the samba-technical mailing list