[PATCH 2/8] Don't ignore testsuites without --list support, but consider them as atomic entities.

Matthieu Patou mat at samba.org
Wed Oct 15 23:58:49 MDT 2014


On Sun, Oct 12, 2014 at 09:18:58PM -0700, Jelmer Vernooij wrote:
> This prevents any such testsuites from being skipped when run using
> testr.
> 
> Bug: https://bugzilla.samba.org/show_bug.cgi?id=10874
> Change-Id: I6ae8c92bb70e86a3b848b9cb3a53e2af466c3fe3
> Signed-Off-By: Jelmer Vernooij <jelmer at samba.org>
> ---
>  selftest/selftest.pl | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/selftest/selftest.pl b/selftest/selftest.pl
> index f35b063..2df5092 100755
> --- a/selftest/selftest.pl
> +++ b/selftest/selftest.pl
> @@ -943,6 +943,9 @@ $envvarstr
>  
>  		unless($cmd =~ /\$LISTOPT/) {
>  			warn("Unable to list tests in $name");
^^^
Shouldn't we change the warning to "Unable to find or list tests in
$name, using $name as the test name" ?
> +			# Rather than ignoring this testsuite altogether, just pretend the entire testsuite is
> +			# a single "test".
> +			print "$name\n";
>  			next;
>  		}
>  
> -- 
> 2.1.1
> 

-- 
Matthieu Patou
Samba Team
http://samba.org


More information about the samba-technical mailing list