master4-dcerpc-ok
Stefan (metze) Metzmacher
metze at samba.org
Fri Mar 21 02:38:00 MDT 2014
Hi Andrew,
>> We could also introduce wrapper functions like
>>
>> const char *dcerpc_binding_get_endpoint(const struct dcerpc_binding *b)
>> {
>> return dcerpc_binding_get_string_option(b, "endpoint");
>> }
>
> This would also be an improvement.
>
>> But the generic dcerpc_binding_[g|s]et_string_option() functions are needed
>> in order to make dcerpc_binding private.
>
> Why can't these helper functions access the private dcerpc_binding?
I may let dcerpc_binding_get_string_option(b, "endpoint") call
dcerpc_binding_get_endpoint() instead.
In the meantime I've removed the commits which need more work from
master4-dcerpc-ok (they're in master4-dcerpc now).
I think master4-dcerpc-ok is now ready for master, can someone review
and push it?
Thanks!
metze
More information about the samba-technical
mailing list