[PATCH] more FSRVP & additionally HRESULT error

Stefan (metze) Metzmacher metze at samba.org
Wed Mar 19 07:25:48 MDT 2014


Hi Noel,

>> ok added full descriptions for existing const defines that had only the
>> short ( e.g. name of the const ) definition but were missing the full
>> description and also added both short and full descriptions for the
>> remaining, see top commit of
>> http://cgit.freedesktop.org/~noelp/noelp-samba/log/?h=heave_in_ntstatus
> 
> Great thanks!

One thing I noticed is that you imported
NT_STATUS_RPC_NT_* values, while we already have some of them
as NT_STATUS_RPC_*. Can you change the import to use just NT_STATUS_RPC_*
and remove the once we already have?

Thanks!
metze


More information about the samba-technical mailing list