[PATCH] libsmb: Put the "smb2_lease" struct into idl
Volker Lendecke
Volker.Lendecke at SerNet.DE
Thu Jun 12 02:57:09 MDT 2014
On Thu, Jun 12, 2014 at 09:18:36AM +0100, Noel Power wrote:
> On 11/06/14 20:01, Volker Lendecke wrote:
> > Hi!
> >
> > Review would be appreciated.
> >
> > Thanks,
> >
> > Volker
> >
>
> - struct smb2_lease_key lease_key;
> - uint32_t lease_state;
> - uint32_t lease_flags;
> - uint64_t lease_duration; /* should be 0 */
> [...]
> -};
>
> + smb2_lease_key lease_key;
> + uint32 lease_state;
> + uint32 lease_flags;
> + uint32 lease_duration; /* should be 0 */
> [...]
> + } smb2_lease;
>
>
> shouldn't lease_duration be 8 bytes e.g. hyper?
Of course! Sorry. Patch attached.
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 419f625fef76f7b786e454b2c3ccc78edf07259b Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 12 Jun 2014 08:53:36 +0000
Subject: [PATCH] leases: Fix uint32->hyper
Thanks to Noel Power <nopower at suse.com> for finding this!
Signed-off-by: Volker Lendecke <vl at samba.org>
---
librpc/idl/smb2_lease_struct.idl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/librpc/idl/smb2_lease_struct.idl b/librpc/idl/smb2_lease_struct.idl
index ea28548..0c581d0 100644
--- a/librpc/idl/smb2_lease_struct.idl
+++ b/librpc/idl/smb2_lease_struct.idl
@@ -26,7 +26,7 @@ interface smb2_lease_struct
smb2_lease_key lease_key;
smb2_lease_state lease_state;
uint32 lease_flags;
- uint32 lease_duration; /* should be 0 */
+ hyper lease_duration; /* should be 0 */
smb2_lease_key parent_lease_key;
uint16 lease_epoch;
} smb2_lease;
--
1.8.1.2
More information about the samba-technical
mailing list