PATCH for use-after-free coverity issue: 242096

[Volker Lendecke]

On Thu, Feb 20, 2014 at 03:57:24PM +0530, Santosh Pradhan wrote:
> Hi Team,
> Please review the patch.
> 
> Thanks,
> Santosh

> >From ddd4a206caa7b9b8e7cac85befd6a4f23ddb0bc9 Mon Sep 17 00:00:00 2001
> From: Santosh Kumar Pradhan <spradhan at redhat.com>
> Date: Thu, 20 Feb 2014 15:51:37 +0530
> Subject: [PATCH] winbindd: Avoid using deallocated memory
> 
> Failure in ads_search_retry() deallocates the memory occupied
> by "ads" which should not be used after.

It's great that you finally want to tackle this can of
worms. We should talk about ripping out ADS_STRUCT and
replace it with something different. We have a few LDAP
access layers around in Samba these days, and this might be
the time to get rid of one particularly error-prone.

Personally, I would love to see tldap used a bit more, but I
would certainly also be happy to see ADS_STRUCT be replaced
by direct LDAP calls using the "standard" C API.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de