[PATCH] RFC debug detect winbindd version mismatches
Noel Power
nopower at suse.com
Fri Feb 14 03:27:19 MST 2014
On 11/02/14 21:58, Andrew Bartlett wrote:
> Thanks for getting back to us, and I do apologise for the delay in
> reviewing this.
>
> On Thu, 2014-01-30 at 09:36 +0000, Noel Power wrote:
>
>> if ((winbind_open_and_version_check_socket(&request, &response) !
>> = NSS_STATUS_SUCCESS) || (response.data.interface_version !=
>> WINBIND_INTERFACE_VERSION)) {
>> return -1;
>> }
> Why do you need to check the interface_version here again? By my
> reading winbind_open_and_version_check_socket should have already done
> that.
was trying maybe too hard to preserve the orig code, does checking
winbindd_fd
e.g.
if (winbindd_fd == -1) {
return -1;
}
work for you?
Noel
More information about the samba-technical
mailing list