[PATCH] Bug #9404 - Notify internal DNS server to reload zones when are added or deleted through RPC

[Andrew Bartlett]

On Tue, 2014-12-16 at 18:11 +0100, Samuel Cabrero wrote:
> Andrew,
> 
> thank you for your comments. I have written a new LDB module and 
> extended the dns.py tests.

Thanks.  That is a good start.  The only issue is that it intercepts all
writes, and we need to be a little less aggressive, so we don't impact
on the speed of the rest of the server.

An additional challenge is ensuring this tests DNS when there is more
than one DNS server - we really should have it do a modify, then force a
replication, then check the OTHER server.  That would show it works for
both local and replicated writes. 

To make this less aggressive, see how the replmd_op_callback function
uses the the DSDB_CONTROL_CURRENT_PARTITION_OID to ask what partition a
operation modified.  You could then compare that with the partitions you
expect DNS zones in.  

Additionally, why do you hook all modifies?  Don't we just need to hook
add and delete?

Thanks,

Andrew Bartlett 

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba