[PATCH] New VFS Module "unityed_media" for sharing AVID projects

Jeremy Allison jra at samba.org
Tue Dec 16 16:20:07 MST 2014


On Mon, Dec 08, 2014 at 06:55:35PM +0100, Ralph Böhme wrote:
> Hi all,
> 
> attached is a new VFS module for improved AVID project sharing, from
> the commit message:
> It's been tested by 3rd party and reported to work flawlessly. Please
> review, comment and/or push if ok.

First comment/fix needed.

get_digit_group() walks through a pathname using:

+       while (*p) {
+               if (isdigit(*p)) {
+                       *digit = (uintmax_t)strtoul(p, &endp, 10);
+                       DEBUG(10, ("num_suffix = '%ju'\n",
+                                             *digit));
+                       return true;
+               }
+               p++;
+       }

This won't work for non-ASCII files. Use next_codepoint()
to walk through pathname strings.


More information about the samba-technical mailing list