Why our autobuilds fail
Stefan (metze) Metzmacher
metze at samba.org
Tue Dec 16 00:58:06 MST 2014
Am 16.12.2014 um 05:29 schrieb Andrew Bartlett:
> On Mon, 2014-12-15 at 12:48 +0100, Michael Adam wrote:
>> Reviewed-by: /me
>>
>> On 2014-12-15 at 10:40 +0100, Stefan (metze) Metzmacher wrote:
>>> Hi,
>>>
>>> here's a patch that makes sure that --with-profiling-data keeps compiling.
>>>
>>> metze
>>>
>
> Sadly, I think we need to revert this.
>
> The issue is, as I read the code and the failed autobuilds, is that the
> first user (your good self) to run this on sn-devel created a shared
> memory segment with a fixed key. See
> source3/profile/profile.c:profile_setup().
>
> All other builds attempt to create the same shared memory segment, and
> refuse to, because they don't own it. This then causes all autobuilds
> to fail.
>
> This isn't an issue in production, as it will always be root, but were a
> distribution to install Samba with this option enabled, it would prevent
> the non-root use of smbd (eg qemu) by multiple users, per reboot.
>
> Can we store the profiling data in a tdb, or at least make the key
> random and put it in a tdb, and can we wipe shared memory segments at
> autobuild completion?
Using a tdb is one of the next things to add,
see
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-profiling
For now I pushed the revert.
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141216/ad473763/attachment.pgp>
More information about the samba-technical
mailing list