TEST: samba4.blackbox.dbcheck.release-4-0-0 fails

[Andreas Schneider]

On Saturday 06 December 2014 05:49:11 Andrew Bartlett wrote:
> On Fri, 2014-12-05 at 17:05 +0100, Andreas Schneider wrote:
> > On Thursday 04 December 2014 09:19:08 Andrew Bartlett wrote:
> > > Is very interesting, as indeed we recently changed the default domain
> > > functional level to 2008R2 in b9701a0a79dd15dd6f53075638fba9a2a3d92e19,
> > > and patched upgradeprovision-oldrelease.sh, but not this file.  Why
> > > doesn't this fail for everyone?
> > 
> > asn at magrathea:~/workspace/projects/samba/git> git bisect bad
> > Bisecting: 0 revisions left to test after this (roughly 0 steps)
> > [b9701a0a79dd15dd6f53075638fba9a2a3d92e19] provision: Change the default
> > functional level of new Samba domains to 2008R2.
> > 
> > Yes, this is the culprit :)
> > 
> > 
> > The attached patch fixes the issue for me. The question is why doesn't it
> > work if the functional level is 2008r2?
> 
> Quite simply because that LDAP attribute represents the functional
> level, and the 4.0.0 provision was made with 2003, so we have to try and
> match that in the new provision before we compare.
> 
> I'm still quite worried that autobuild let this past.

Yes, I wonder too why this does not fail in autobuild. I normally compile 
Samba with the options used by RHEL and SLES and run a full 'make test' from 
time to time to find issues with this option set.

Running ./configure.developer --libdir=/usr/lib64    --enable-fhs   --
prefix=/usr   --sbindir=/usr/sbin   --localstatedir=/var   --
sysconfdir=/etc/samba   --with-statedir=/var/lib/samba   --with-
configdir=/etc/samba   --with-lockdir=/var/lib/samba   --with-
logfilebase=/var/log/samba   --with-piddir=/run   --with-privatedir=/etc/samba   
--with-pammodulesdir=/lib64/security   --disable-rpath-install   --enable-cups   
--disable-gnutls   --bundled-libraries=heimdal,!zlib,!popt   --with-shared-
modules=vfs_cacheprime,vfs_readahead,idmap_ad,idmap_ldap,idmap_rid,pdb_tdbsam,pdb_ldapsam,pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4,auth_netlogond,auth_samba4   
--with-pam   --without-pam_smbpass   --without-fam   --with-cluster-support   
--with-profiling-data   --with-systemd

Did you try to run the test on your machine?

source selftest/devel_env.sh
make -j test TESTS="samba4.blackbox.dbcheck.release-4-0-0"

To see if it works or fails? Someone else?


	-- andreas


-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org