fix warning message on cifs-utils build - alternate package name for krb5.h

Jeff Layton jlayton at samba.org
Mon Sep 9 19:00:47 CEST 2013


On Mon, 9 Sep 2013 09:59:38 -0500
Steve French <smfrench at gmail.com> wrote:

> commit 5c69761267eb54ce0d94f3a30c3ad015efd3a806
> Author: Steve French <smfrench at gmail.com>
> Date:   Mon Sep 9 09:55:46 2013 -0500
> 
>     [CIFS-UTILS] Add another suggested package name for krb5 headers
> 
>     Added an alternate package name for krb5 headers.
> 
>     Noticed the following suggestion asks for the wrong package (at least
>     wrong for FC17)
> 
>     checking krb5.h presence... no
>     checking for krb5.h... no
>     checking krb5/krb5.h usability... no
>     checking krb5/krb5.h presence... no
>     checking for krb5/krb5.h... no
>     configure: WARNING: krb5.h not found, consider installing
>     krb5-libs-devel. Disabling cifs.upcall.
> 
>     [sfrench at w500smf cifs-utils]$ sudo yum install krb5-libs-devel
>     Loaded plugins: langpacks, presto, refresh-packagekit
>     No package krb5-libs-devel available.
>     Error: Nothing to do
>     [sfrench at w500smf cifs-utils]$ sudo yum install krb5-devel
> 
>     (installing krb5-devel worked, but not krb5-libs-devel for this version)
> 
>     Signed-off-by: Steve French <smfrench at gmail.com>
> 
> diff --git a/configure.ac b/configure.ac
> index b5f7c49..c69ede4 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -135,9 +135,9 @@ if test $enable_cifsupcall != "no"; then
>   if test x$ac_cv_header_krb5_krb5_h != xyes ; then
>   if test x$ac_cv_header_krb5_h != xyes ; then
>   if test "$enable_cifsupcall" = "yes"; then
> - AC_MSG_ERROR([krb5.h not found, consider installing krb5-libs-devel.])
> + AC_MSG_ERROR([krb5.h not found, consider installing krb5-devel or
> krb5-libs-devel.])
>   else
> - AC_MSG_WARN([krb5.h not found, consider installing krb5-libs-devel.
> Disabling cifs.upcall.])
> + AC_MSG_WARN([krb5.h not found, consider installing krb5-devel or
> krb5-libs-devel. Disabling cifs.upcall.])
>   enable_cifsupcall="no"
>   fi
>   fi
> 

Looks like your mailer is mangling your patches:

patch -p1 < fix\ warning\ message\ on\ cifs-utils\ build\ -\ alternate\ package\ name\ for\ krb5.h 
patching file configure.ac
patch: **** malformed patch at line 89: krb5-libs-devel.])

I'm guessing you pasted the patch into your mail client? That generally
doesn't work well. You may want to resend using git-send-email.

-- 
Jeff Layton <jlayton at samba.org>


More information about the samba-technical mailing list