[Patch] use enums instead of int32

Stefan (metze) Metzmacher metze at samba.org
Mon Oct 21 00:19:52 MDT 2013


Hi Matthieu,

> -	typedef [switch_type(int32)] union {
> -		[case(1)] drsuapi_DsGetDCInfoRequest1 req1;
> +	typedef [switch_type(drsuapi_DsGetDCInfoCtrLevels)] union {
> +		[case(DRSUAPI_DC_INFO_CTR_1)] drsuapi_DsGetDCInfoRequest1 req1;
>  	} drsuapi_DsGetDCInfoRequest;
>
...
>  	WERROR drsuapi_DsGetDomainControllerInfo(
>  		[in] policy_handle *bind_handle,
> -		[in] int32 level,
> +		[in] drsuapi_DsGetDCInfoCtrLevels level,
>  		[in,ref,switch_is(level)] drsuapi_DsGetDCInfoRequest *req,

Please keep the request level as int32 (or uint32 depending what
Microsoft uses).
The rest looks good.

metze


More information about the samba-technical mailing list