[PATCH] winbind: Print error code on connection error in ping_dc
Michael Adam
obnox at samba.org
Sat May 25 05:03:42 MDT 2013
I also review+ and would push,
but before pushing, since is currently in discussion:
Christof: Can we add your "signed-off-by" tag?
In the future, could you post patches with sign-off?
I assume that your patches are submitted under personal
copyright. correct?
Cheers - Michael
On 2013-05-24 at 17:05 -0700, Jeremy Allison wrote:
> On Fri, May 24, 2013 at 12:40:49PM -0700, Christof Schmitt wrote:
> > For debugging, it is useful to include the error code in the message.
> > ---
> > source3/winbindd/winbindd_dual_srv.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
> > index 744e251..e23d048 100644
> > --- a/source3/winbindd/winbindd_dual_srv.c
> > +++ b/source3/winbindd/winbindd_dual_srv.c
> > @@ -690,7 +690,8 @@ NTSTATUS _wbint_PingDc(struct pipes_struct *p, struct wbint_PingDc *r)
> > status = cm_connect_netlogon(domain, &netlogon_pipe);
> > reset_cm_connection_on_error(domain, status);
> > if (!NT_STATUS_IS_OK(status)) {
> > - DEBUG(3, ("could not open handle to NETLOGON pipe\n"));
> > + DEBUG(3, ("could not open handle to NETLOGON pipe: %s\n",
> > + nt_errstr(status)));
> > return status;
> > }
>
> +1 Reviewed-by: Jeremy Allison <jra at samba.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 206 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130525/d9092b0a/attachment.pgp>
More information about the samba-technical
mailing list