[PATCHES] Patches for the AD DC

[Andrew Bartlett]

On Fri, 2013-05-17 at 00:40 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> > On 05/16/2013 04:45 AM, Andrew Bartlett wrote:
> >> Attached is a series of patches I've been working on in various places,
> >> all collected up.  I'm doing a private autobuild on these now, but I've
> >> cut them down so that they pass a number of DRS tests that were a
> >> problem before.
> >>
> >> In any case, some review of these would be nice.
> >>
> >> In particular, I now have code to handle and test (!) some more complex
> >> rename situations that I think we were getting wrong before.
> >>
> >> Andrew Bartlett
> > Patch dsdb-linked_attributes: Do not error when we cannot find the backlink
> > 
> > Can you add a debug message if we are not returning an error if the
> > fowardlink has no backlink ?
> 
> I also thought that.
> 
> I'm also wondering in what situation this could happen?
> Can you explain that?

It came up in my testing.  I'll re-add in the patches that triggered it
and show you.  I couldn't understand it either, when I examined the
databases at the end the objects that caused the crash were present, and
we set all the magic 'really show me the objects' flags. 

> Regarding the dsdb-repl_meta_data: rename change, I have to go through
> this in detail
> an try to understand the change.

I'll also try and go and add more comments and doc links.  Essentially
what it does is force renames though the same code for finding a valid
parent as additions use, as previously we trusted the whole string DN,
without using the parent GUID at all.  The fact that this is all tied up
in the async with callbacks just makes it crazy to follow, but I was
very glad to be able to re-use the code from the add case. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org