[PATCH] Add tests for our NFSv4 ACL code

Andrew Bartlett abartlet at samba.org
Mon May 6 12:47:58 MDT 2013


On Mon, 2013-05-06 at 19:06 +0200, Christian Ambach wrote:
> On 04/29/2013 12:11 AM, Andrew Bartlett wrote:
> 
> >> These bugs are actually all already in samba 4.0 master and they are not
> >> introduced by this patchset.
> >
> > Yep.  They are fixed in my nfsv4-2 branch however (the first commit),
> > except for the ppdesc error, which I can't make sense of.
> 
> Unfortunately, you didn't catch them all but I found some time to
> attempt to compile your branch on an AIX machine (with some help by 
> Alexander).
> 
> Necessary patches are attached.
> 
> Maybe we should add vfs_aixacl2 to the list of module to be built by 
> default on AIX so we can at least catch such errors in the buildfarm?

I certainly think we should.  Indeed, I think we should similarly always
build zfsacls if we are on a supporting platform and likewise for all
the other optional modules.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list