[PATCH] build and use-after free fixes found during Solaris work

[Andrew Bartlett]

On Wed, 2013-03-27 at 13:00 +1030, Rusty Russell wrote:
> Andrew Bartlett <abartlet at samba.org> writes:
> 
> > On Solaris-derived systems (OpenIndiana in this case) I found we needed
> > to avoid the libidmap.so name, and I found a use-after-free in the auth
> > code at debug level 5.
> >
> > See Attached, please review and or push.
> 
> Hmm... I can't git-am that mail, since it applies it as one commit.
> 
> If I munpack to extract the attachmentds, git-am doesn't like the >
> before the top from, so I have to edit it manually.

Yeah, it seems if the patch ever goes via an mbox format at any point in
the path, the From lines get munged.  Sadly it's not something I can
easily fix in my workflow/mailer. 

> And while I can read these patches, I actually reviewed your git tree,
> where I could grep and look at files to see if you'd missed anything.
> 
> And if I were to apply and push these, I'm implicitly doing a rebase.
> That's fine for these little patches, but for more serious work it can
> hide problems.

All samba patches go via a rebase anyway, due to autobuild.  

> Finally, you didn't Sign-off either of them, but that seems normal?

Yes, that's normal.  We only defined a protocol for that for corporate
contributors with LGPL licence to the team, as I own my own copyrights,
I don't want to add to the confusion. 

> Patches are fine, BTW :)

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org