[PATCH] Fix for bug #9706 - Parameter is incorrect on Android
Andreas Schneider
asn at samba.org
Mon Mar 18 04:33:03 MDT 2013
On Friday 15 March 2013 14:56:00 Jeremy Allison wrote:
> On Fri, Mar 15, 2013 at 11:40:21AM -0700, Jeremy Allison wrote:
> > Ok, I've done the tests. Looks like the correct response
> > is to return shorter reads than what the client asks if
> > the reads are out of range. The only case where we should
> > still fail is when the read request out of range and is
> > done in an andX chain, so I've left that code check in
> > place.
> >
> > I have a modified server patch that does this. It'll make
> > Andrew happy as we no longer need to look at RA_SAMBA, as
> > we just cope in the same way as Windows does with whatever
> > the client asks for. All we do is modify max_pdu to cope
> > with what the client told us it can cope with. Client tests
> > also expanded to cope with signed+sealed requests as well
> > as the new read values.
> >
> > I'll post on the bug and a new patchset here shortly.
>
> And here is the fixed patchset. It applies cleanly
> to master.. I'll also upload a 4.0.next version
> to the bug report.
>
> Please test and push if you're happy with it.
The patchset looks fine for me. I will run the test here and then push it.
Please update the patchset in the bug report!!
-- andreas
--
Andreas Schneider GPG-ID: F33E3FC6
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list