[PATCH] Implement machinepass= in 'net ads join'
Andrew Bartlett
abartlet at samba.org
Tue Mar 5 08:45:19 MST 2013
On Mon, 2013-03-04 at 16:43 -0800, Jeremy Allison wrote:
> On Mon, Mar 04, 2013 at 04:15:29PM -0800, Jeremy Allison wrote:
> >
> > Ok, this causes make test to fail on the "s4member" samba3.wbinfo_s3.(s4member:local)
> > test. Reproduce by doing:
> >
> > make test TESTS=samba3.wbinfo_s3
> >
> > It only seems to be starting the s4 server as a member server, not as a DC
> > to authenticate against, so I think this part of the patch should change from:
> >
> > +# this test simply confirms that forcing the machine account password in the join command works
> > +for env in ["s3member", "s4member"]:
> > + plantestsuite("samba3.blackbox.smbclient_specified_machine_auth.plain (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_specified_machine_auth.sh"), '$DC_SERVER', '$SERVER\$', 'machine$PASSWORD', smbclient3, configuration])
> > +
> >
> > to:
> >
> > +# this test simply confirms that forcing the machine account password in the join command works
> > +for env in ["s3member"]:
> > + plantestsuite("samba3.blackbox.smbclient_specified_machine_auth.plain (%s)" % env, env, [os.path.join(samba3srcdir, "script/tests/test_smbclient_specified_machine_auth.sh"), '$DC_SERVER', '$SERVER\$', 'machine$PASSWORD', smbclient3, configuration])
> > +
> >
> > Can you confirm (or fix what I don't understand about the breakage :-)
> > and re-submit ?
>
> Ok, here's a patchset that passes make test. It includes
> the change in the test.py file.
>
> Can you confirm this is ok and I'll push to master ?
Drat! I'm really not doing well here am I? :-)
So, what actually happened is that the hunk in the first patch was
right, but I put it in the wrong spot - right in the middle of an
existing for loop - causing the remaining code in the old loop to be in
the new one I just made!
This (attached) is what I really meant, and is in my
add_net_ads_machinepass branch. The only issue is that despite 2 hours
of banging my head against a brick wall, I now have both a sore head and
no progress in getting autobuild to pass with it.
I can run the test manually, but not as part of autobuild! My only
last-moment thought is that something changes the machine account
password during make test. If that's the case, we may have no option
but to drop the test :-(
Andrew Bartlett
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: net_ads_machinepassword.patch
Type: text/x-patch
Size: 17266 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130306/6fb18841/attachment.bin>
More information about the samba-technical
mailing list