[PATCH] Fix crash on Samba AD DC LDAP server

[Jeremy Allison]

On Mon, Jun 24, 2013 at 10:19:07PM +1000, Andrew Bartlett wrote:
> On Mon, 2013-06-24 at 22:05 +1000, Andrew Bartlett wrote:
> > On Sat, 2013-06-22 at 17:04 +1000, Andrew Bartlett wrote:
> > > On Sat, 2013-06-22 at 08:20 +1000, Andrew Bartlett wrote:
> > > > On Fri, 2013-06-21 at 00:55 -0700, Matthieu Patou wrote:
> > > > > The patch is good but it means that the search will also never succeed.
> > > > > 
> > > > > you can add my review:
> > > > > 
> > > > > reviewed-by: Matthieu Patou <mat at matws.net>
> > > > > 
> > > > > Don't forget your sign-off !
> > > > 
> > > > Not succeeding seems to be the expected thing - attributes without
> > > > values don't exist in LDAP.
> > > > 
> > > > I'll get this in, and in the meanwhile I'm trying to figure out how to
> > > > write a test for this.
> > > 
> > > Tests and fixes for ldb and libcli/ldap (needed for the tests) are
> > > attached. 
> > > 
> > > Please review.
> > > 
> > > Thanks,
> > 
> > Additionally this patch bumps the ldb version number.
> > 
> > Please also review this.
> 
> Attached is the full patch set fixing the crash/DoS issue.  As we have
> the release freeze for 4.0 tomorrow, I would very much appreciate it if
> someone could please review these changes for me, so we can include it.
> We have not decided to do a distinct release as it is 'only' an
> authenticated DoS, but we should not miss this scheduled release either.

LGTM - pushed. Good work, thanks !

Jeremy.