[PATCH 4/5 linux-next V2] cifs: fix incorrect reference count check
Jeff Layton
jlayton at redhat.com
Mon Dec 9 04:03:21 MST 2013
On Sun, 8 Dec 2013 14:08:43 -0700
Tim Gardner <timg at tpi.com> wrote:
> The reference count on tlink can only be decremented if
> cifs_sb_tlink(cifs_sb) was used to acquire it. That only
> happens if open_file==NULL.
>
> Cc: Steve French <sfrench at samba.org>
> Cc: Jeff Layton <jlayton at redhat.com>
> Cc: Dean Gehnert <deang at tpi.com>
> Signed-off-by: Tim Gardner <timg at tpi.com>
> ---
>
> V2 - this is a new patch in the V2 series.
>
> fs/cifs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c
> index 3f710c6..e332038 100644
> --- a/fs/cifs/inode.c
> +++ b/fs/cifs/inode.c
> @@ -2007,7 +2007,7 @@ cifs_set_file_size(struct inode *inode, struct iattr *attrs,
> CIFSSMBClose(xid, tcon, netfid);
> }
> }
> - if (tlink)
> + if (!open_file)
> cifs_put_tlink(tlink);
>
> set_size_out:
I don't see the bug here...
The only place tlink gets set to a non-NULL value is where
cifs_sb_tlink gets called. Am I missing something?
--
Jeff Layton <jlayton at redhat.com>
More information about the samba-technical
mailing list