[PATCH v5] Remove excessive log messages generated when opening directories.

Christopher R. Hertel crh at ubiqx.mn.org
Thu Aug 29 16:36:34 MDT 2013


Based on a conversation with Abartlet, I've created a new patch that
completely removes the logging.  Avati confirmed that Gluster-level errors
are logged via a different mechanism, and Samba handles the errors passed
back from the VFS module.  Any logging done in vfs_glusterfs_open() is,
therefore, redundant.

I was also treated to this bit wisdom, of which I had be previously unaware:

  http://en.wikipedia.org/wiki/Parkinson%27s_law_of_triviality

New patch attached.

Please review and approve...or whatever.

Chris -)-----

-- 
"Implementing CIFS - the Common Internet FileSystem" ISBN: 013047116X
Samba Team -- http://www.samba.org/     -)-----   Christopher R. Hertel
jCIFS Team -- http://jcifs.samba.org/   -)-----   ubiqx development, uninq.
ubiqx Team -- http://www.ubiqx.org/     -)-----   crh at ubiqx.mn.org
OnLineBook -- http://ubiqx.org/cifs/    -)-----   crh at ubiqx.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Master-vfs_glusterfs-Fix-excessive-debug-output-from-vfs_gl-v5.patch
Type: text/x-patch
Size: 1615 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130829/cabab48c/attachment.bin>


More information about the samba-technical mailing list