[PATCH] samba-tool - MX records cannot be deleted (error in called C-program)

[Amitay Isaacs]

On Mon, Apr 15, 2013 at 3:58 AM, Günter Kukkukk <linux at kukkukk.com> wrote:

> Am Sonntag, 14. April 2013, 13:38:53 schrieb Andrew Bartlett:
> > On Sun, 2013-04-14 at 06:37 +0200, Günter Kukkukk wrote:
> > > please review and push - it's an obvious glitch.
> >
> > Well spotted.  It's a pity the tests didn't pick this up.  Could you add
> > one?
> >
> > Thanks, it is now in master.
> >
> > Andrew Bartlett
>
> I looked at this late in the night with tired eyes,
> so i missed another wrong compare in the same
> statement, sorry.
>

Nice catch.


> Kai has already written a test for this, which did not
> pass autobuild due to corrupted dns data.
>

I thought that test did not use samba-tool, but use DNS protocol to update
and query.


>
> I already had a short look at that code, must dig deeper now...
>

I have few patches in my dns-wip branch that fix SOA handling.


>
> Please review and push this one, too.
>
> Cheers, Günter
>

Amitay.