[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL
simo
idra at samba.org
Fri Oct 12 11:59:16 MDT 2012
On Fri, 2012-10-12 at 10:10 -0700, Jeremy Allison wrote:
> On Fri, Oct 12, 2012 at 09:59:38AM -0400, simo wrote:
> >
> > Sorry for being late here, but what is the point of all those
> > talloc_stackframe() / TALLOC_FREE(frame) call pairs in the posix_acls()
> > code ?
> >
> > Why not just use talloc_tos() ?
>
> My argument exactly :-). I pushed back on this initially too :-).
Right I am really concerned about calling talloc_stackframe() in every
minor function and would like to understand the rationale.
If there is no clear rationale that pattern should be reverted.
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical
mailing list