returning values on talloc_tos() (was Re: [PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL)
simo
idra at samba.org
Wed Oct 10 06:50:31 MDT 2012
On Wed, 2012-10-10 at 19:37 +1100, Andrew Bartlett wrote:
> On Wed, 2012-10-10 at 08:37 +0200, Volker Lendecke wrote:
> > On Tue, Oct 09, 2012 at 02:41:04PM -0700, Jeremy Allison wrote:
> > > On Wed, Oct 10, 2012 at 07:50:03AM +1100, Andrew Bartlett wrote:
> > > Right now we only have 3 VFS calls that take an explicit
> > > context. I'm not sure adding context to the ACL calls
> > > is the right move here. It's doable, but I'd like more
> > > input before we decide.
> > >
> > > Richard, Volker or Metze, can you comment ? You've
> > > guys have probably written more VFS modules than anyone
> > > else.
> > >
> > > Explicit context for [F]GET_NT_ACL() calls or talloc_tos() ?
> >
> > Explicit context please.
>
> Thanks Volker. I've prepared the attached two patches to do this.
>
> I'm testing these and a broken-up set of patches for my other changes
> now. For the curious, the whole series is at
> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/fix-acls2
Nack (minor issues)
Patch 1:
Andrew,
please:
- do not add spaces at the end of lines
(you are often adding a space at least after the 'SMB_ACL_TYPE_T type,
argument)
- if you are reformatting a function try to keep lines within 80 chars
(you can fix a lot of functions declaration that you are changing,
+ a lot of code in posix_acls.c you are changing)
- if you are changing a line remove things like double spaces between
arguments while you are there
(ex: skel_sys_acl_get_file() )
For review it would be much better if you can split the first patch in
three:
1. Changes the actual posix_Acl code
2. Mechanical changes to all vfs modules
3. additional changes to things like python wrappers
Patch 2:
Git message has repeated 'as as', I guess the second was meant to be
just an 'a'
please:
- do not add spaces at the end of lines
(almost all fns arguments you added/modified for example)
- keep lines within 80 chars
Simo.
--
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>
More information about the samba-technical
mailing list