[PATCHES] Make add_remove_group_members a private helper function and partial fixes for Bug #8891

[Lukasz Zalewski]

Hi Jelmer, list

First patch makes the add_remove_group_members a private helper function 
and adds separate calls to add and remove members.

Second and third patch provide a partial fix for Bug #8891.
The reason why i said partial, is that the bug contains a mix of 
problems and feature requests, and only the following have been addressed:

* addmembers/removemembers will throw an exception for any of the users 
for which a DN cannot be found.

* adding a group member that already exists or removing member that does 
not exist will not be silently ignored - instead a ldb exception
Attribute member already exists for target GUID ... (when adding), or
Attribute member already deleted for target GUID ... (when removing)
will be produced

* trying to list members of nonexistent group will produce an exception

Things that have not been addressed:
* Inability to add/remove members which have existed before migration 
from s3 to s4 - I'm hoping the new error handling will provide more 
information to why it is failing.

* listgroups/memberof (feature request) has not been implemented yet

Regards

L

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samdb-make-add_remove_group_members-a-private-helper.patch
Type: text/x-patch
Size: 12669 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120625/07297a2e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-samdb-Better-exception-handling-in-_add_remove_group.patch
Type: text/x-patch
Size: 4935 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120625/07297a2e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s4-netcmd-group.py-throw-exception-when-nonexistent-.patch
Type: text/x-patch
Size: 1130 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120625/07297a2e/attachment-0002.bin>