s3: temporary hack to make the waf build work withouth autotools being required
Björn Jacke
bj at sernet.de
Tue Jun 5 16:38:34 MDT 2012
On 2012-06-06 at 08:15 +1000 Andrew Bartlett sent off:
> On Tue, 2012-06-05 at 23:57 +0200, Björn Jacke wrote:
> > The branch, master has been updated
> > via f1becfa s3: temporary hack to make the waf build work withouth autotools being required
> > from 8693a4f s3:lib: split things into a conn_tdb.h
> >
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> >
> >
> > - Log -----------------------------------------------------------------
> > commit f1becfa27b6b4e35541e6df0cafdec0ad47d2e3f
> > Author: Björn Jacke <bj at sernet.de>
> > Date: Tue Jun 5 21:56:19 2012 +0200
> >
> > s3: temporary hack to make the waf build work withouth autotools being required
> >
> > this also disables the examples/VFS build for waf now. Finally we should create a
> > wscript file for examples/VFS.
> >
> > Autobuild-User: Björn Jacke <bj at sernet.de>
> > Autobuild-Date: Tue Jun 5 23:56:22 CEST 2012 on sn-devel-104
> >
> > -----------------------------------------------------------------------
> >
> > Summary of changes:
> > source3/Makefile.in | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> >
> > Changeset truncated at 500 lines:
> >
> > diff --git a/source3/Makefile.in b/source3/Makefile.in
> > index 7b27833..fe05250 100644
> > --- a/source3/Makefile.in
> > +++ b/source3/Makefile.in
> > @@ -3388,6 +3388,7 @@ bin/ndrdump4: $(BINARY_PREREQS)
> > vfs_examples:
> > ( \
> > cd ../examples/VFS && \
> > + test -e ./configure || exit 0 && \
> > ./configure && \
> > make clean && \
> > make \
>
> I'm a little confused, so if you don't mind, can you fill me in a little
> more on the background here? We have a wscript file for examples/VFS,
> but the waf build won't ever use source3/Makefile.in.
>
> I'm of course all in favour of making the waf build work in more places
> - I'm just trying to make sure I understand exactly how this helps.
>
> Do you mean instead that this allows the 'everything' build to run on
> more systems, and then do a waf build for smbtorture4?
right, the commit text is not really right as there is already a wscript file
and yes, the buildfarm errors came from the waf build for smbtorture4
actually, which was trying and failing to call "configure" in the vfs_examples
makefile target accordingly. Sorry for the misleading text. The vfs_examples
build just needs some rework and the call of configure in the Makefile ought to
be obsoleted, too.
Cheers
Björn
More information about the samba-technical
mailing list