getpass regressions on Solaris/Illumos - 3.6 and master.

[Jeremy Allison]

On Tue, Jan 31, 2012 at 02:57:24AM +0100, Jiri Sasek - Solaris Prague wrote:
> Hi Jeremy,
> 
> I do not understand so much of this "gymnastics" here so I start to
> worry  :-)
> 
> Some longer time ago I asked to replace getpass() which represents
> the original AT&T UNIX API (it has internal buffer for 8 chars!!! no
> more!!! more chars entered are ignored) by getpassphrase() which has
> also the internal buffer but 256chars long. Both calls are
> prototyped in /usr/include/stdlib.h  ...what kind of the regression
> it is? Is it introduced with the new waf build system?
> 
> I do not understand full context of the proposed patches. But
> add_getpass.patch looks more like the changes I asked for a time
> ago. So I vote for add_getpass.patch.
> 
> Best regards,

Thanks Jiri. I've pushed this to master and once metze approves
(if he approves :-) it'll get into 3.6.next.

Cheers,

	Jeremy.