[PATCH 1/2] tdb: Fix possible crash bugs in the python tdb code.

Andreas Schneider asn at samba.org
Wed Dec 12 03:32:04 MST 2012


On Tuesday 11 December 2012 21:03:17 Jelmer Vernooij wrote:
> On Tue, 2012-12-11 at 18:26 +0100, Andreas Schneider wrote:
> > You can't call tdb_error() for tdb_reopen() or tdb_close(), both return
> > the error code of close(2) and not a TDB_ERROR!
> 
> Thanks! ACK (feel free to add my Reviewed-By).
> 
> Bonus points for a follow-up that adds tests that trigger these error
> conditions.

Well I don't know how to do this cause I would need to modify the C structure 
(change the fd to somthing insane) or call close() directly on the fd. I'm not 
such an advanced python programmer.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list