On Thu, Apr 05, 2012 at 04:00:21PM +1000, Andrew Bartlett wrote: Thanks ! > largefile branch with one more patch, to remove SMB_OFF_T, and replace > with just off_t. Let me know what you think. That also sounds a really good idea to simplify the code - thanks ! Jeremy.