[PATCH] Have ldbmodify and ldbadd operate in a single transaction

Stefan (metze) Metzmacher metze at samba.org
Wed Apr 4 04:21:59 MDT 2012


Am 04.04.2012 11:13, schrieb Andrew Bartlett:
> The attached patches make ldbmodify and ldbadd operate in a single
> transaction, and abort that transaction on failure. 
> 
> Matthieu, this also reverts your previous attempt at doing this.  It
> should help your schema work, as each transaction causes a schema
> reload, which can be a problem for mutually dependent schema items.
> 
> It also fixes up our tests to both pass and cause failures on failure,
> by wrapping it in the right subunit. 
> 
> I've also put them in my git tree:
> https://git.samba.org/abartlet/samba.git/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/ldb-one-transaction

Can we add an option to control the behavior?
For things like the ldap backend we don't have transactions anyway,
we might want to return an error there if the caller asks for a single
transaction.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20120404/d4c9f3e3/attachment.pgp>


More information about the samba-technical mailing list